OpencachingDeutschland/oc-server3
1
0
Fork 0
Code Issues Pull Requests Releases Activity

fix for 4582: "uknown error" when saving user profile

Browse Source 
Changed coordinates were detected due to direct comparison of float numbers
in row editor. This caused unexpected state when saving unchanged user
profile details.

Fixed by adding epsilon threshold.
This commit is contained in:
following
2012-10-29 00:24:09 +01:00
parent b298bfccc0
commit 42c1f54f99
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
htdocs/lib2/logic/rowEditor.class.php
+8 -1
View File
@@ -346,7 +346,14 @@ class rowEditor
return false;
$sFormatedValue = $this->pFormatValue($this->fields[$sField]['type'], $sValue);
if ($this->fields[$sField]['value'] != $sFormatedValue)
if ($this->fields[$sField]['type'] == RE_TYPE_FLOAT)
// Direct float comparison is deprecated and can result in last-digit errors.
// Floats in OC database are only used for reasonably large numbers like coordinates,
// waylengths and time estimates, so using a fixed epsilon threshold is safe:
$changed = (abs($sFormatedValue - $this->fields[$sField]['value']) >= 1e-13);
else
$changed = ($sFormatedValue != $this->fields[$sField]['value']);
if ($changed)
{
$this->fields[$sField]['value'] = $sFormatedValue;
$this->fields[$sField]['changed'] = true;