OpencachingDeutschland/oc-server3
1
0
Fork 0
Code Issues Pull Requests Releases Activity

fixed email address escaping in maillog cronjob

Browse Source 
'&' in email addresses was misinterpreted as placeholder indication
This commit is contained in:
following 2013-08-30 19:34:12 +02:00
parent 43c0004a85
commit a651bb7324
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
htdocs/util2/cron/modules/maillog.class.php
View File

@ -36,7 +36,8 @@ class maillog
$dbc = @mysql_connect($opt['system']['maillog']['syslog_db_host'], $dbc = @mysql_connect($opt['system']['maillog']['syslog_db_host'],
$opt['system']['maillog']['syslog_db_user'], $opt['system']['maillog']['syslog_db_user'],
$opt['system']['maillog']['syslog_db_password']); $opt['system']['maillog']['syslog_db_password'],
TRUE); // use separate connection even if on same DB host
if ($dbc === FALSE) if ($dbc === FALSE)
{ {
echo $this->name.": could not connect to syslog database\n"; echo $this->name.": could not connect to syslog database\n";
@ -78,12 +79,13 @@ class maillog
$emailadr = $matches[1]; $emailadr = $matches[1];
if ($delivered) if ($delivered)
sql("UPDATE `user` SET `email_problems`=0 sql("UPDATE `user` SET `email_problems`=0
WHERE `email`='" . mysql_real_escape_string($emailadr) . "'"); WHERE `email`='&1'", $emailadr);
else if ($bounced) else if ($bounced)
// maximum one bounce per day is counted, to filter out temporary problems // maximum one bounce per day is counted, to filter out temporary problems
sql("UPDATE `user` SET `email_problems`=`email_problems`+1, `last_email_problem`='" . mysql_real_escape_string($logentry['created']) . "' sql("UPDATE `user` SET `email_problems`=`email_problems`+1, `last_email_problem`='&2'
WHERE `email`='" . mysql_real_escape_string($emailadr) . "' WHERE `email`='&1' AND IFNULL(`last_email_problem`,'') < '&2'",
AND IFNULL(`last_email_problem`,'') < '" . mysql_real_escape_string(substr($logentry['created'],0,10)) . "'"); $emailadr,
$logentry['created']);
} }
else else
echo $this->name.": no email address found for record ID ".$logentry['id']."\n"; echo $this->name.": no email address found for record ID ".$logentry['id']."\n";