New class for handling field definitions.

.gitignore

@@ -1,5 +1,6 @@
 /_devel_/
 /js/*.js
+/clover.xml
 
 # Composer stuff
 /auth.json

lib/Frs/FieldDefinition.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace Frs;
+
+class FieldDefinition
+{
+    private $field_data = array();
+
+    /**
+     * @param string $type Type of FieldDefinition (hotel, car, etc.)
+     * @throws \Exception if no definition file for this $type is found
+     */
+    public function __construct($type)
+    {
+        $definition_file = 'definitions/' . $type . '.json';
+        if (!file_exists($definition_file)) {
+            throw new \Exception('File ' . $definition_file . ' not found!');
+        }
+        $field_data_json  = file_get_contents($definition_file);
+        $this->field_data = json_decode($field_data_json, true);
+    }
+
+    public function getFieldData()
+    {
+        return $this->field_data;
+    }
+
+    public function getGroups()
+    {
+        $by_group = array();
+        foreach ($this->field_data['groups'] as $id=>$group) {
+            $by_group[$group] = array(
+                'group_name' => $group,
+                'fields'     => array(),
+            );
+        }
+        return $by_group;
+    }
+}

phpunit.xml.dist

@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="utf-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.5/phpunit.xsd"
+    bootstrap="./vendor/autoload.php"
+    verbose="true">
+    <filter>
+        <whitelist processUncoveredFilesFromWhitelist="false">
+            <!-- this is the path of the files included in your clover report -->
+            <directory suffix=".php">./</directory>
+            <directory suffix=".php">./lib/</directory>
+            <exclude>
+                <directory suffix=".php">./tests/</directory>
+                <directory suffix=".php">./vendor</directory>
+            </exclude>
+        </whitelist>
+    </filter>
+    <logging>
+        <log type="coverage-clover" target="./clover.xml"/>
+        <log type="coverage-text" target="php://stdout" showUncoveredFiles="false"/>
+    </logging>
+    <testsuites>
+        <testsuite name="FRS">
+            <directory>./tests/</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

prep_form.php

@@ -1,5 +1,7 @@
 <?php
 
+use \Frs\FieldDefinition;
+
 // FOR TESTING:
 if (!isset($action)) {
     $action = 'hotel';
@@ -7,16 +9,9 @@ if (!isset($action)) {
 }
 $skey   = 'form_' . $action;
 
-$field_data_json = file_get_contents('definitions/' . $action . '.json');
+$fd = new FieldDefinition($action);
-$field_data = json_decode($field_data_json, true);
+$field_data = $fd->getFieldData();
-
+$by_group = $fd->getGroups();
-// Build Group list
-foreach ($field_data['groups'] as $id=>$group) {
-    $by_group[$group] = array(
-        'group_name' => $group,
-        'fields' => array(),
-    );
-}
 
 // Assign fields to groups, fill in (default) values
 foreach ($field_data['fields'] as $key=>$meta) {

prep_mail.php

@@ -1,5 +1,7 @@
 <?php
 
+use \Frs\FieldDefinition;
+
 // FOR TESTING:
 if (!isset($action)) {
     $action = 'hotel';
@@ -7,8 +9,8 @@ if (!isset($action)) {
 }
 $skey   = 'form_' . $action;
 
-$field_data_json = file_get_contents('definitions/' . $action . '.json');
+$fd = new FieldDefinition($action);
-$field_data = json_decode($field_data_json, true);
+$field_data = $fd->getFieldData();
 
 $fields = array();
 

tests/FieldDefinitionTest.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Frs\Tests;
+
+#use \PHPUnit\Framework\TestCase;
+
+class FieldDefinitionTest extends \PHPUnit_Framework_TestCase
+{
+    public function testTrue()
+    {
+        $this->assertTrue(true);
+    }
+}