From 7288ffdef8eef24915a7bf27820460d0adc7238a Mon Sep 17 00:00:00 2001 From: Matthias Mees Date: Mon, 3 Dec 2012 13:35:59 +0100 Subject: [PATCH] Fixed most of the redundant br elements in the core. --- include/admin/comments.inc.php | 6 +-- include/admin/images.inc.php | 2 +- include/admin/importers/blogger.inc.php | 27 +++++++------ include/admin/importers/generic.inc.php | 19 ++++----- include/admin/importers/livejournal.inc.php | 4 +- include/admin/importers/movabletype.inc.php | 12 +++--- include/admin/importers/old_blogger.inc.php | 40 +++++++++---------- include/admin/importers/pivot.inc.php | 20 +++++----- include/admin/importers/serendipity.inc.php | 25 ++++++------ include/admin/importers/smf.inc.php | 2 +- include/admin/importers/sunlog.inc.php | 5 +-- include/admin/importers/textpattern.inc.php | 2 +- include/admin/importers/voodoopad.inc.php | 15 ++++--- include/admin/importers/wordpress.inc.php | 38 +++++++++--------- include/admin/plugins.inc.php | 4 +- include/admin/upgrader.inc.php | 8 ++-- include/functions.inc.php | 4 +- include/functions_config.inc.php | 8 ++-- include/functions_entries.inc.php | 4 +- include/functions_entries_admin.inc.php | 8 ++-- include/functions_images.inc.php | 28 ++++++------- include/functions_plugins_admin.inc.php | 2 +- include/functions_rss.inc.php | 2 +- include/functions_trackbacks.inc.php | 44 ++++++++++----------- include/plugin_api.inc.php | 2 +- include/plugin_internal.inc.php | 4 +- include/template_api.inc.php | 2 +- serendipity_admin.php | 5 +-- 28 files changed, 172 insertions(+), 170 deletions(-) diff --git a/include/admin/comments.inc.php b/include/admin/comments.inc.php index 180047ea..ca9faff3 100644 --- a/include/admin/comments.inc.php +++ b/include/admin/comments.inc.php @@ -20,15 +20,15 @@ if ($serendipity['POST']['formAction'] == 'multiDelete' && sizeof($serendipity[' foreach ( $serendipity['POST']['delete'] as $k => $v ) { $ac = serendipity_approveComment($k, $v, false, 'flip'); if ($ac > 0) { - $errormsg .= DONE . ': '. sprintf(COMMENT_APPROVED, (int)$k) . '
'; + $errormsg .= DONE . ': '. sprintf(COMMENT_APPROVED, (int)$k); } else { - $errormsg .= DONE . ': '. sprintf(COMMENT_MODERATED, (int)$k) . '
'; + $errormsg .= DONE . ': '. sprintf(COMMENT_MODERATED, (int)$k); } } } else { foreach ( $serendipity['POST']['delete'] as $k => $v ) { serendipity_deleteComment($k, $v); - $errormsg .= DONE . ': '. sprintf(COMMENT_DELETED, (int)$k) . '
'; + $errormsg .= DONE . ': '. sprintf(COMMENT_DELETED, (int)$k); } } } diff --git a/include/admin/images.inc.php b/include/admin/images.inc.php index 04921692..53b2db91 100644 --- a/include/admin/images.inc.php +++ b/include/admin/images.inc.php @@ -648,7 +648,7 @@ switch ($serendipity['GET']['adminAction']) { $data['case_scale'] = true; $data['print_SCALING_IMAGE'] = sprintf( - SCALING_IMAGE . '
', + SCALING_IMAGE, $file['path'] . $file['name'] .'.'. $file['extension'], (int)$serendipity['GET']['width'], (int)$serendipity['GET']['height'] diff --git a/include/admin/importers/blogger.inc.php b/include/admin/importers/blogger.inc.php index 52edba6c..767ac422 100644 --- a/include/admin/importers/blogger.inc.php +++ b/include/admin/importers/blogger.inc.php @@ -39,9 +39,9 @@ class Serendipity_Import_Blogger extends Serendipity_Import { function getImportNotes(){ if (empty($_REQUEST['token'])) { - $msg = 'In order to import your blog on Blogger, Serendipity needs to be able to access it via Google\'s Blogger Data APIs.
'; - $msg .= 'Login to your Google/Blogger account and then click the link below.

'; - $msg .= 'Go to Google to grant access
'; + $msg = 'In order to import your blog on Blogger, Serendipity needs to be able to access it via Google\'s Blogger Data APIs.'; + $msg .= 'Login to your Google/Blogger account and then click the link below.'; + $msg .= 'Go to Google to grant access'; return $msg; } else { return ''; @@ -154,7 +154,7 @@ class Serendipity_Import_Blogger extends Serendipity_Import { } // Export success - echo 'Successfully exported entries from Blogger
'; + echo 'Successfully exported entries from Blogger'; // Get Serendipity authors list $authorList = array(); @@ -247,29 +247,32 @@ class Serendipity_Import_Blogger extends Serendipity_Import { } // Report on resultant authors - echo '
Current list of authors:
'. join(', ', array_values($authorList)) .'

'; + echo 'Current list of authors: '. join(', ', array_values($authorList)); // Do cleanup and report on entries - echo 'The following entries were successfully imported:
'; + echo 'The following entries were successfully imported:'; + echo ''; // Report fails - echo 'The following entries ran into trouble and was not imported:
'; + echo 'The following entries ran into trouble and was not imported:'; + echo ''; // Reset autodiscovery $serendipity['noautodiscovery'] = $noautodiscovery; // All done! - echo "Import finished.
"; + echo 'Import finished.'; return true; } @@ -277,4 +280,4 @@ class Serendipity_Import_Blogger extends Serendipity_Import { return 'Serendipity_Import_Blogger'; -?> \ No newline at end of file +?> diff --git a/include/admin/importers/generic.inc.php b/include/admin/importers/generic.inc.php index 38887319..f059d7a4 100644 --- a/include/admin/importers/generic.inc.php +++ b/include/admin/importers/generic.inc.php @@ -143,18 +143,18 @@ class Serendipity_Import_Generic extends Serendipity_Import { if (PEAR::isError($res) || $req->getResponseCode() != '200') { serendipity_request_end(); - echo IMPORT_FAILED . ': ' . htmlspecialchars($this->data['url']); - echo "
\n"; + echo '' . IMPORT_FAILED . ': ' . htmlspecialchars($this->data['url']) . ''; return false; } $fContent = $req->getResponseBody(); serendipity_request_end(); - echo strlen($fContent) . " Bytes
\n"; + echo '' . strlen($fContent) . " Bytes"; if (version_compare(PHP_VERSION, '5.0') === -1) { + echo ''; printf(UNMET_REQUIREMENTS, 'PHP >= 5.0'); - echo "
\n"; + echo ""; return false; } @@ -194,9 +194,9 @@ class Serendipity_Import_Generic extends Serendipity_Import { 'parentid' => 0, 'category_left' => 0, 'category_right' => 0); - + echo ''; printf(CREATE_CATEGORY, htmlspecialchars($cat_name)); - echo "
\n"; + echo ""; if ($dry_run) { $s9y_cat[$cat_name] = time(); } else { @@ -235,7 +235,7 @@ class Serendipity_Import_Generic extends Serendipity_Import { foreach($item->category AS $idx => $category) { $cstring=(string)$category; if (!isset($s9y_cat[$cstring])) { - echo "WARNING: $category unset!
\n"; + echo "WARNING: $category unset!"; } else { $entry['categories'][] = $s9y_cat[$cstring]; } @@ -252,8 +252,9 @@ class Serendipity_Import_Generic extends Serendipity_Import { } else { $s9y_users[$wp_user]['authorid'] = serendipity_addAuthor($wp_user, md5(time()), $wp_user, '', USERLEVEL_EDITOR); } + echo ''; printf(CREATE_AUTHOR, htmlspecialchars($wp_user)); - echo "
\n"; + echo ""; } $entry['authorid'] = $s9y_users[$wp_user]['authorid']; @@ -308,7 +309,7 @@ class Serendipity_Import_Generic extends Serendipity_Import { $s9y_cid[$c_id] = $cid; } - echo "Entry '" . htmlspecialchars($entry['title']) . "' ($c_i comments) imported.
\n"; + echo "Entry '" . htmlspecialchars($entry['title']) . "' ($c_i comments) imported."; } return true; } diff --git a/include/admin/importers/livejournal.inc.php b/include/admin/importers/livejournal.inc.php index 21292e55..2665b05e 100644 --- a/include/admin/importers/livejournal.inc.php +++ b/include/admin/importers/livejournal.inc.php @@ -253,7 +253,7 @@ class Serendipity_Import_LiveJournalXML extends Serendipity_Import { } } $id = serendipity_updertEntry($new_entry); - echo 'Inserted entry #' . $id . ', "' . htmlspecialchars($new_entry['title']) . '"
' . "\n"; + echo 'Inserted entry #' . $id . ', "' . htmlspecialchars($new_entry['title']) . '"'; if (is_array($new_entry['comments'])) { $cid_map = array(); $jids = array(); @@ -265,7 +265,7 @@ class Serendipity_Import_LiveJournalXML extends Serendipity_Import { $cid = serendipity_insertComment($id, $comment); $cid_map[$comment['jtalkid']] = $cid; } - echo 'Inserted comments for entry #' . $id . '
' . "\n"; + echo 'Inserted comments for entry #' . $id . ''; } if (function_exists('ob_flush')) { diff --git a/include/admin/importers/movabletype.inc.php b/include/admin/importers/movabletype.inc.php index 4bee5108..18aa2fe4 100644 --- a/include/admin/importers/movabletype.inc.php +++ b/include/admin/importers/movabletype.inc.php @@ -67,7 +67,7 @@ class Serendipity_Import_MovableType extends Serendipity_Import { if ($debug) { $c++; - echo '#' . $c . ' [' . date('d.m.Y H:i.s') . '] ' . $string . "
\n"; + echo '#' . $c . ' [' . date('d.m.Y H:i.s') . '] ' . $string . ""; } } @@ -139,7 +139,7 @@ class Serendipity_Import_MovableType extends Serendipity_Import { $au_inf = serendipity_fetchAuthor($data); if ( !is_array($au_inf) ) { $tasks[] = sprintf(CREATE_AUTHOR, htmlspecialchars($data)); - $tasks[] = 'Input array is: ' . print_r($data, true) . '
Return is: ' . print_r($au_inf, true) . '
'; + $tasks[] = ''; $au_inf = serendipity_fetchAuthor($serendipity['authorid']); } $authors[$data] = $au_inf[0]; @@ -183,7 +183,9 @@ class Serendipity_Import_MovableType extends Serendipity_Import { $cat_found = false; if (is_array($this->categories)) { for ( $y=0 ; $ycategories) ; $y++ ) { - echo '"' . $this->categories[$y]['category_name'] . '" == "' . $data . '"
'; + echo ''; + echo '"' . $this->categories[$y]['category_name'] . '" == "' . $data; + echo ''; if ( $this->categories[$y]['category_name'] == $data ) { $cat_found = true; break; @@ -425,7 +427,7 @@ class Serendipity_Import_MovableType extends Serendipity_Import { if ( !sizeof($tasks) || $force == true ) { serendipity_db_begin_transaction(); foreach ($entries as $entry) { - #echo '
' . printR_($entry, true) . '

'; + #echo '
' . printR_($entry, true) . '
'; #continue; if (empty($entry['authorid'])) { $entry['authorid'] = $serendipity['authorid']; @@ -472,4 +474,4 @@ class Serendipity_Import_MovableType extends Serendipity_Import { } } return 'Serendipity_Import_MovableType'; -?> \ No newline at end of file +?> diff --git a/include/admin/importers/old_blogger.inc.php b/include/admin/importers/old_blogger.inc.php index 2b42bd73..bcd7ce99 100644 --- a/include/admin/importers/old_blogger.inc.php +++ b/include/admin/importers/old_blogger.inc.php @@ -59,7 +59,7 @@ class Serendipity_Import_OldBlogger extends Serendipity_Import {

BLOGGER.COM to SERENDIPITY IMPORT

Version 0.1,( 29/10/2005 )

-


+

1. First go to Blogger.com, login.

2. Go to the templates section. Set the following as your template. You should backup the current template if you want to reset it back after this operation. Click "Save template changes" button to save this new template.

@@ -97,10 +97,8 @@ ENDPOST

9. Now in the box below type in the path to the "index.html" file blogger created under your "blogger" directory. File path should then look something like "/httpdocs/blogger/index.html".

10. This script will create the users as from the blogger blog being imported. However if a user already exists, then that user will be used instead of creating a new user with similar name. For the new users that this script will create, you need to provide a default password. Type it in the box below.

11. Click "Submit". Your posts and comments should be imported to serendipity!

-

If you have questions or problems, feel free to drop me a mail at jaa at technova dot com dot mv.
-
-Jaa
-http://jaa.technova.com.mv

'; +

If you have questions or problems, feel free to drop me a mail at jaa at technova dot com dot mv.

+

Jaa, http://jaa.technova.com.mv

'; return $out; } @@ -127,45 +125,45 @@ http://jaa.technova.com.mv

'; # locate the post title if (preg_match("/TITLE:(.*)/", $post, $title)) { $title = trim($title[1]); - echo "" . htmlspecialchars($title) . "
"; + echo "" . htmlspecialchars($title) . ""; } else { $title = ""; - echo "Empty title
"; + echo "Empty title"; } # locate the post author if (preg_match("/AUTHOR:(.*)/", $post, $author)) { $author = trim($author[1]); - echo "" . htmlspecialchars($author[1]) . "
"; + echo "" . htmlspecialchars($author[1]) . ""; } else { $author = ""; - echo "Unknown author
"; + echo "Unknown author"; } # locate the post date if (preg_match("/DATE:(.*)/", $post, $date)) { $date = strtotime(trim($date[1])); - echo "Posted on " . htmlspecialchars($date[1]) . ".
"; + echo "Posted on " . htmlspecialchars($date[1]) . "."; } else { $date = time(); - echo "Unknown posting time.
"; + echo "Unknown posting time."; } # locate the post body if (preg_match("/BODY:(.*)-----/sU", $post, $body)) { $body = trim($body[1]); - echo strlen($body) . " Bytes of text.
"; + echo '' . strlen($body) . " Bytes of text."; } else { $body = ""; - echo "Empty Body!
"; + echo "Empty Body!"; } # find all comments for the post using pattern matching if (preg_match_all( "/COMMENT:(.*)----/sU", $post, $commentlist)) { - echo count($commentlist[1]) . " comments found.
"; + echo '' . count($commentlist[1]) . " comments found."; } else { $commentlist = array(); - echo "No comments found.
"; + echo "No comments found."; } $result = serendipity_db_query("SELECT authorid FROM ". $serendipity['dbPrefix'] ."authors WHERE username = '". serendipity_db_escape_string($author) ."' LIMIT 1", true, 'assoc'); @@ -192,12 +190,12 @@ http://jaa.technova.com.mv

'; 'authorid' => $authorid ); - echo "Entry insert...
"; + echo "Entry insert..."; if (!is_int($id = serendipity_updertEntry($entry))) { - echo "Inserting entry failed.
"; + echo "Inserting entry failed."; return $id; } else { - echo "Entry $id inserted.
"; + echo "Entry $id inserted."; } # iterate through all comments @@ -242,10 +240,10 @@ http://jaa.technova.com.mv

'; } serendipity_db_query("UPDATE ". $serendipity['dbPrefix'] ."entries SET comments = ". $c ." WHERE id = ". $id); - echo "Comment count set to: ". $c ."
"; + echo "Comment count set to: ". $c .""; } - echo "Import finished.
"; + echo "Import finished."; return true; } @@ -254,4 +252,4 @@ http://jaa.technova.com.mv

'; return 'Serendipity_Import_OldBlogger'; /* vim: set sts=4 ts=4 expandtab : */ -?> \ No newline at end of file +?> diff --git a/include/admin/importers/pivot.inc.php b/include/admin/importers/pivot.inc.php index 76fc9b92..a286df7b 100644 --- a/include/admin/importers/pivot.inc.php +++ b/include/admin/importers/pivot.inc.php @@ -74,7 +74,7 @@ class Serendipity_Import_Pivot extends Serendipity_Import { $this->data['pivot_path'] = $check_dir; } - printf('
' . CHECKING_DIRECTORY . '

', $this->data['pivot_path']); + printf('' . CHECKING_DIRECTORY . ': ', $this->data['pivot_path']) . ''; if ($root = opendir($this->data['pivot_path'])) { // Fetch category data: $s9y_categories = serendipity_fetchCategories('all'); @@ -83,6 +83,7 @@ class Serendipity_Import_Pivot extends Serendipity_Import { 'categories' => array() ); + echo ''; } else { return sprintf(ERROR_NO_DIRECTORY, $this->data['pivot_path']); } diff --git a/include/admin/importers/serendipity.inc.php b/include/admin/importers/serendipity.inc.php index 06ec304c..df5d2e51 100644 --- a/include/admin/importers/serendipity.inc.php +++ b/include/admin/importers/serendipity.inc.php @@ -17,12 +17,11 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { function getImportNotes() { // TODO: I18n! - return 'This importer is still work in progress. It can currently import most things of the database. HOWEVER it can NOT import previously installed plugins (including their configuration) or any database tables of installed plugins. Those must be migrated manually. Also, you must use FTP to transfer your uploaded images to the new location.
- Please do a test-run first if you are SQL-savvy. If you encounter any errors, save the message output you get - it will definitely help debugging!
-
- This is NOT an importer meant for upgrading Serendipity. This importer assumes that both Serendipity installations use the same version.
- It is strongly advised that you test this importer in an isolated environment first, do not use it on a production blog unless you made sure it works in a cloned installation. Always make a backup of both the source and the target blog.

- After these precautions: The importer code generally works very well for me and my purposes. Your mileage may vary.'; + return '

This importer is still work in progress. It can currently import most things of the database. HOWEVER it can NOT import previously installed plugins (including their configuration) or any database tables of installed plugins. Those must be migrated manually. Also, you must use FTP to transfer your uploaded images to the new location.

+

Please do a test-run first if you are SQL-savvy. If you encounter any errors, save the message output you get - it will definitely help debugging!

+

This is NOT an importer meant for upgrading Serendipity. This importer assumes that both Serendipity installations use the same version.

+

It is strongly advised that you test this importer in an isolated environment first, do not use it on a production blog unless you made sure it works in a cloned installation. Always make a backup of both the source and the target blog.

+

After these precautions: The importer code generally works very well for me and my purposes. Your mileage may vary.

'; } function Serendipity_Import_Serendipity ($data) { @@ -96,7 +95,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { function import_table(&$s9ydb, $table, $primary_keys, $where = null, $dupe_check = false, $fix_relations = false, $skip_dupes = false) { global $serendipity; - echo "

Starting with table {$table}...
\n"; + echo "Starting with table {$table}..."; if ($dupe_check) { $dupes = serendipity_db_query("SELECT * FROM {$serendipity['dbPrefix']}" . $table . " " . $where, false, 'both', false, $dupe_check); @@ -161,7 +160,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { } if (!$this->execute && $this->debug) { - echo "Fix relation from $fix_relation_table.$fix_relation_primary_key={$primary_vals[$fix_relation_primary_key]} to {$row[$primary_key]} (assoc_val: $assoc_val)
\n"; + echo "Fix relation from $fix_relation_table.$fix_relation_primary_key={$primary_vals[$fix_relation_primary_key]} to {$row[$primary_key]} (assoc_val: $assoc_val)"; } } } @@ -170,7 +169,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { if ($insert) { if ($dupe_check && isset($dupes[$row[$dupe_check]])) { if ($this->debug) { - echo "Skipping duplicate: 
" . print_r($dupes[$row[$dupe_check]], true) . "

\n"; + echo "Skipping duplicate: 
" . print_r($dupes[$row[$dupe_check]], true) . "
"; } foreach($primary_vals AS $primary_key => $primary_val) { $this->storage[$table][$primary_key][$primary_val] = $dupes[$row[$dupe_check]][$primary_key]; @@ -182,7 +181,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { $dbid = serendipity_db_insert_id($table, $primary_key); $this->storage[$table][$primary_key][$primary_val] = $dbid; } - echo "Migrated entry #{$dbid} into {$table}.
\n"; + echo "Migrated entry #{$dbid} into {$table}."; } else { if ($this->debug) { echo 'DB Insert: 
' . print_r($row, true) . '
'; @@ -199,7 +198,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { } } else { if ($this->debug && !$this->execute) { - echo "Ignoring Duplicate.
\n"; + echo "Ignoring Duplicate."; } } } @@ -207,7 +206,7 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { if (!$this->execute) { echo 'Storage on '. $table . ':
' . print_r($this->storage[$table], true) . '
'; } else { - echo "Finished table {$table}
\n"; + echo "Finished table {$table}"; } } @@ -470,4 +469,4 @@ class Serendipity_Import_Serendipity extends Serendipity_Import { return 'Serendipity_Import_Serendipity'; -/* vim: set sts=4 ts=4 expandtab : */ \ No newline at end of file +/* vim: set sts=4 ts=4 expandtab : */ diff --git a/include/admin/importers/smf.inc.php b/include/admin/importers/smf.inc.php index 1a496f68..dc726ffe 100644 --- a/include/admin/importers/smf.inc.php +++ b/include/admin/importers/smf.inc.php @@ -13,7 +13,7 @@ class Serendipity_Import_smf extends Serendipity_Import { var $categories = array(); function getImportNotes() { - return 'SMF uses salted MD5 passwords that Serendipity cannot import. Thus, those passwords are incompatible with the MD5 hashing of Serendipity. The passwords for all users have been set to a random string. You need to modify the passwords manually for each user, we are sorry for that inconvenience.
'; + return '

SMF uses salted MD5 passwords that Serendipity cannot import. Thus, those passwords are incompatible with the MD5 hashing of Serendipity. The passwords for all users have been set to a random string. You need to modify the passwords manually for each user, we are sorry for that inconvenience.

'; } function Serendipity_Import_smf($data) { diff --git a/include/admin/importers/sunlog.inc.php b/include/admin/importers/sunlog.inc.php index e21fd485..b5121597 100644 --- a/include/admin/importers/sunlog.inc.php +++ b/include/admin/importers/sunlog.inc.php @@ -13,9 +13,8 @@ class Serendipity_Import_sunlog extends Serendipity_Import { var $categories = array(); function getImportNotes() { - return 'Sunlog uses a crypted string to represent stored passwords. Thus, those passwords are incompatible with the MD5 hashing of Serendipity and can not be reconstructed. The passwords for all users have been set to "sunlog". You need to modify the passwords manually for each user, we are sorry for that inconvenience.
' - . '
' - . 'Sunlog has a granular control over access privileges which cannot be migrated to Serendipity. All Users will be migrated as Superusers, you may need to set them to editor or chief users manually after import.'; + return '

Sunlog uses a crypted string to represent stored passwords. Thus, those passwords are incompatible with the MD5 hashing of Serendipity and can not be reconstructed. The passwords for all users have been set to "sunlog". You need to modify the passwords manually for each user, we are sorry for that inconvenience.

' + . '

Sunlog has a granular control over access privileges which cannot be migrated to Serendipity. All Users will be migrated as Superusers, you may need to set them to editor or chief users manually after import.

'; } function Serendipity_Import_sunlog($data) { diff --git a/include/admin/importers/textpattern.inc.php b/include/admin/importers/textpattern.inc.php index 7b6898b1..5b22bd9b 100644 --- a/include/admin/importers/textpattern.inc.php +++ b/include/admin/importers/textpattern.inc.php @@ -13,7 +13,7 @@ class Serendipity_Import_textpattern extends Serendipity_Import { var $categories = array(); function getImportNotes() { - return 'Textpattern uses MySQLs native PASSWORD() function to save passwords. Thus, those passwords are incompatible with the MD5 hashing of Serendipity. The passwords for all users have been set to "txp". You need to modify the passwords manually for each user, we are sorry for that inconvenience.
'; + return '

Textpattern uses MySQLs native PASSWORD() function to save passwords. Thus, those passwords are incompatible with the MD5 hashing of Serendipity. The passwords for all users have been set to "txp". You need to modify the passwords manually for each user, we are sorry for that inconvenience.

'; } function Serendipity_Import_textpattern($data) { diff --git a/include/admin/importers/voodoopad.inc.php b/include/admin/importers/voodoopad.inc.php index c27e30be..941761b7 100755 --- a/include/admin/importers/voodoopad.inc.php +++ b/include/admin/importers/voodoopad.inc.php @@ -82,7 +82,7 @@ class Serendipity_Import_VoodooPad extends Serendipity_Import { // Dependency on static pages if (!class_exists('serendipity_event_staticpage')) { - die(IMPORTER_VOODOO_REQUIREMENTFAIL . '
'); + die('' . IMPORTER_VOODOO_REQUIREMENTFAIL . ''); } // The selected file @@ -160,18 +160,18 @@ class Serendipity_Import_VoodooPad extends Serendipity_Import { // Either replace or insert depending on previous existence if (!isset($thispage['id'])) { - echo '
'.IMPORTER_VOODOO_CREATINGPAGE.': '. $mykey; + echo ''.IMPORTER_VOODOO_CREATINGPAGE.': '. $mykey.''; serendipity_db_insert('staticpages', $thispage); $serendipity["POST"]["staticpage"] = serendipity_db_insert_id("staticpages", 'id'); } elseif ($this->data['updateExisting'] == 'true') { - echo '
'.IMPORTER_VOODOO_UPDATINGPAGE.': '. $mykey; + echo ''.IMPORTER_VOODOO_UPDATINGPAGE.': '. $mykey.''; serendipity_db_update("staticpages", array("id" => $thispage["id"]), $thispage); } else { - echo '
'.IMPORTER_VOODOO_NOTUPDATING.': '. $mykey; + echo ''.IMPORTER_VOODOO_NOTUPDATING.': '. $mykey.''; } } else { // If its a url, the content is the link instead - echo '
'.IMPORTER_VOODOO_RECORDURL.': '.$thispage['headline']; + echo ''.IMPORTER_VOODOO_RECORDURL.': '.$thispage['headline'].''; $aliases[$thispage['headline']] = $thispage['content']; } break; @@ -179,7 +179,6 @@ class Serendipity_Import_VoodooPad extends Serendipity_Import { } // Now rewrite the permalinks - echo '
'; if ($this->data['shouldWriteLinks'] == 'true') { Serendipity_Import_VoodooPad::write_links($aliases); } @@ -192,7 +191,7 @@ class Serendipity_Import_VoodooPad extends Serendipity_Import { global $serendipity; // **TODO** Change this to pull out only entries for the current wiki - echo '

'.IMPORTER_VOODOO_WRITEINTRALINKS.'

'; + echo '

'.IMPORTER_VOODOO_WRITEINTRALINKS.'

'; $pages= &serendipity_db_query("SELECT * FROM {$serendipity['dbPrefix']}staticpages ORDER BY pagetitle DESC"); @@ -210,7 +209,7 @@ class Serendipity_Import_VoodooPad extends Serendipity_Import { serendipity_db_update("staticpages", array("id" => $thispage["id"]), $thispage); } - echo DONE . '
'; + echo '' . DONE . ''; } // Search and replace avoiding content of links diff --git a/include/admin/importers/wordpress.inc.php b/include/admin/importers/wordpress.inc.php index 3c0cba5c..25a06d9c 100644 --- a/include/admin/importers/wordpress.inc.php +++ b/include/admin/importers/wordpress.inc.php @@ -110,7 +110,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { if (!$res) { printf(COULDNT_SELECT_USER_INFO, mysql_error($wpdb)); } else { - if ($debug) echo "Importing users...
\n"; + if ($debug) echo "Importing users..."; for ($x=0, $c = mysql_num_rows($res) ; $x < $c ; $x++) { $users[$x] = mysql_fetch_assoc($res); @@ -137,7 +137,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { // Set association. $assoc['users'][$users[$x]['ID']] = $users[$x]['authorid']; } - if ($debug) echo "Imported users.
\n"; + if ($debug) echo "Imported users."; // Clean memory unset($users); @@ -152,7 +152,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { if (!$res) { $no_cat = mysql_error($wpdb); } else { - if ($debug) echo "Importing categories (WP 2.2 style)...
\n"; + if ($debug) echo "Importing categories (WP 2.2 style)..."; // Get all the info we need for ($x=0 ; $x\n"; - if ($debug) echo "Rebuilding category tree...
\n"; + if ($debug) echo "Imported categories."; + if ($debug) echo "Rebuilding category tree..."; serendipity_rebuildCategoryTree(); - if ($debug) echo "Rebuilt category tree.
\n"; + if ($debug) echo "Rebuilt category tree."; } /* Categories (WP >= 2.3 style) */ @@ -219,7 +219,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { $no_cat = mysql_error($wpdb); } elseif ($res) { $no_cat = false; - if ($debug) echo "Importing categories (WP 2.3 style)...
\n"; + if ($debug) echo "Importing categories (WP 2.3 style)..."; // Get all the info we need for ($x=0 ; $x\n"; - if ($debug) echo "Rebuilding category tree...
\n"; + if ($debug) echo "Imported categories."; + if ($debug) echo "Rebuilding category tree..."; serendipity_rebuildCategoryTree(); - if ($debug) echo "Rebuilt category tree.
\n"; + if ($debug) echo "Rebuilt category tree."; } if ($no_cat) { printf(COULDNT_SELECT_CATEGORY_INFO, $no_cat); @@ -282,7 +282,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { if (!$res) { printf(COULDNT_SELECT_ENTRY_INFO, mysql_error($wpdb)); } else { - if ($debug) echo "Importing entries...
\n"; + if ($debug) echo "Importing entries..."; for ($x=0, $c = mysql_num_rows($res) ; $x < $c ; $x++ ) { $entries[$x] = mysql_fetch_assoc($res); @@ -300,13 +300,13 @@ class Serendipity_Import_WordPress extends Serendipity_Import { if (!is_int($entries[$x]['entryid'] = serendipity_updertEntry($entry))) { printf(COULDNT_SELECT_ENTRY_INFO, mysql_error($wpdb)); - echo "ID: {$entries[$x]['ID']} - {$entry['title']}
\n"; + echo "ID: {$entries[$x]['ID']} - {$entry['title']}"; return $entries[$x]['entryid']; } $assoc['entries'][$entries[$x]['ID']] = $entries[$x]['entryid']; } - if ($debug) echo "Imported entries...
\n"; + if ($debug) echo "Imported entries..."; // Clean memory unset($entries); @@ -318,13 +318,13 @@ class Serendipity_Import_WordPress extends Serendipity_Import { if (!$res) { $no_entrycat = mysql_error($wpdb); } else { - if ($debug) echo "Importing category associations (WP 2.2 style)...
\n"; + if ($debug) echo "Importing category associations (WP 2.2 style)..."; while ($a = mysql_fetch_assoc($res)) { $data = array('entryid' => $assoc['entries'][$a['post_id']], 'categoryid' => $assoc['categories'][$a['category_id']]); serendipity_db_insert('entrycat', $this->strtrRecursive($data)); } - if ($debug) echo "Imported category associations.
\n"; + if ($debug) echo "Imported category associations."; } /* Entry/category (WP > 2.3 style)*/ @@ -335,13 +335,13 @@ class Serendipity_Import_WordPress extends Serendipity_Import { $no_entrycat = mysql_error($wpdb); } elseif ($res) { $no_entrycat = false; - if ($debug) echo "Importing category associations (WP 2.3 style)...
\n"; + if ($debug) echo "Importing category associations (WP 2.3 style)..."; while ($a = mysql_fetch_assoc($res)) { $data = array('entryid' => $assoc['entries'][$a['post_id']], 'categoryid' => $assoc['categories'][$a['category_id']]); serendipity_db_insert('entrycat', $this->strtrRecursive($data)); } - if ($debug) echo "Imported category associations.
\n"; + if ($debug) echo "Imported category associations."; } if ($no_entrycat) { @@ -354,7 +354,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { printf(COULDNT_SELECT_COMMENT_INFO, mysql_error($wpdb)); } else { $serendipity['allowSubscriptions'] = false; - if ($debug) echo "Importing comments...
\n"; + if ($debug) echo "Importing comments..."; while ($a = mysql_fetch_assoc($res)) { $comment = array('entry_id ' => $assoc['entries'][$a['comment_post_ID']], 'parent_id' => 0, @@ -373,7 +373,7 @@ class Serendipity_Import_WordPress extends Serendipity_Import { serendipity_approveComment($cid, $assoc['entries'][$a['comment_post_ID']], true); } } - if ($debug) echo "Imported comments.
\n"; + if ($debug) echo "Imported comments."; } $serendipity['noautodiscovery'] = $noautodiscovery; diff --git a/include/admin/plugins.inc.php b/include/admin/plugins.inc.php index a640ccc0..d2e38031 100644 --- a/include/admin/plugins.inc.php +++ b/include/admin/plugins.inc.php @@ -372,8 +372,8 @@ if (isset($_GET['serendipity']['plugin_to_conf'])) { /* Load the new plugin */ $plugin = &serendipity_plugin_api::load_plugin($inst); if (!is_object($plugin)) { - echo "DEBUG: Plugin $inst not an object: " . print_r($plugin, true) . ".
Input: " . print_r($serendipity['GET'], true) . ".

\n\nThis error can happen if a plugin was not properly downloaded (check your plugins directory if the requested plugin was downloaded) or the inclusion of a file failed (permissions?)
\n"; - echo "Backtrace:
\n" . implode("
\n", $serendipity['debug']['pluginload']) . "
"; + echo "
DEBUG: Plugin $inst not an object: " . print_r($plugin, true) . ".
Input: " . print_r($serendipity['GET'], true) . ".
This error can happen if a plugin was not properly downloaded (check your plugins directory if the requested plugin was downloaded) or the inclusion of a file failed (permissions?)
"; + echo "
Backtrace:
" . implode("
\n", $serendipity['debug']['pluginload']) . "
"; } $bag = new serendipity_property_bag; $plugin->introspect($bag); diff --git a/include/admin/upgrader.inc.php b/include/admin/upgrader.inc.php index b96ccd8e..767d8080 100644 --- a/include/admin/upgrader.inc.php +++ b/include/admin/upgrader.inc.php @@ -94,7 +94,7 @@ $tasks = array(array('version' => '0.5.1', 'function' => 'serendipity_removeFiles', 'title' => 'Removal of obsolete files', 'arguments' => array($obsolete_files), - 'desc' => 'The directory structure has been reworked. The following files will be moved to a folder called "backup". If you made manual changes to those files, be sure to read the file docs/CHANGED_FILES to re-implement your changes.
' . implode(', ', $obsolete_files) . '
'), + 'desc' => '

The directory structure has been reworked. The following files will be moved to a folder called "backup". If you made manual changes to those files, be sure to read the file docs/CHANGED_FILES to re-implement your changes.

' . implode(', ', $obsolete_files) . '
'), array('version' => '0.8-alpha4', 'function' => 'serendipity_removeFiles', @@ -142,9 +142,9 @@ $tasks = array(array('version' => '0.5.1', 'function' => 'serendipity_fixPlugins', 'arguments' => array('markup_column_names'), 'title' => 'Configuration options of markup plugins', - 'desc' => 'Because of the latest multilingual improvements in Serendipity, the database key names for certain configuration directives only found in markup plugins need to be renamed.
' - . 'This will be automatically handled by Serendipity for all internally bundled and external plugins. If you are using the external plugins "GeShi" and "Markdown", please make sure you will upgrade to their latest versions!
' - . 'We also advise that you check the plugin configuration of all your markup plugins (like emoticate, nl2br, s9ymarkup, bbcode) and see if the settings you made are all properly migrated.'), + 'desc' => '

Because of the latest multilingual improvements in Serendipity, the database key names for certain configuration directives only found in markup plugins need to be renamed.

' + . '

This will be automatically handled by Serendipity for all internally bundled and external plugins. If you are using the external plugins "GeShi" and "Markdown", please make sure you will upgrade to their latest versions!

' + . '

We also advise that you check the plugin configuration of all your markup plugins (like emoticate, nl2br, s9ymarkup, bbcode) and see if the settings you made are all properly migrated.

'), array('version' => '0.8-beta5', 'function' => 'serendipity_smarty_purge', diff --git a/include/functions.inc.php b/include/functions.inc.php index 135bfd8a..45d9536f 100644 --- a/include/functions.inc.php +++ b/include/functions.inc.php @@ -936,14 +936,14 @@ function serendipity_displayTopUrlList($list, $limit, $use_links = true, $interv foreach ($rows as $row) { if ($use_links) { printf( - '%2$s (%3$s)
', + '%2$s (%3$s)', htmlspecialchars($row['scheme']), htmlspecialchars($row['host']), htmlspecialchars($row['total']) ); } else { printf( - '%1$s (%2$s)
', + '%1$s (%2$s)', htmlspecialchars($row['host']), htmlspecialchars($row['total']) ); diff --git a/include/functions_config.inc.php b/include/functions_config.inc.php index 4b22c9e5..73e2e6ba 100644 --- a/include/functions_config.inc.php +++ b/include/functions_config.inc.php @@ -803,6 +803,7 @@ function serendipity_iframe(&$entry, $mode = null, $use_smarty = true) { $show = false; switch ($mode) { case 'save': + echo '
'; echo '
'; $res = serendipity_updertEntry($entry); @@ -817,15 +818,16 @@ function serendipity_iframe(&$entry, $mode = null, $use_smarty = true) { $entrylink = serendipity_archiveURL($res, $entry['title'], 'serendipityHTTPPath', true, array('timestamp' => $entry['timestamp'])); echo '
' . ENTRY_SAVED . ' (' . VIEW . ')
'; } - echo '
'; + echo '
'; $show = true; break; case 'preview': + echo '
'; echo '
'; serendipity_printEntries(array($entry), ($entry['extended'] != '' ? 1 : 0), true); - echo '
'; + echo '
'; $show = true; break; @@ -879,7 +881,7 @@ function serendipity_iframe_create($mode, &$entry) { echo '

'; + . ''; } /** diff --git a/include/functions_entries.inc.php b/include/functions_entries.inc.php index b79faddf..92c6a589 100644 --- a/include/functions_entries.inc.php +++ b/include/functions_entries.inc.php @@ -1500,7 +1500,7 @@ function serendipity_generateCategoryList($cats, $select = array(0), $type = 0, if ($cat['parentid'] == $id) { switch ($type) { case 0: - $ret .= str_repeat(' ', $level * 2).'• ' . (!empty($cat['category_icon']) ? '' . $cat['category_name'] . ' ' : '') . htmlspecialchars($cat['category_name']) . (!empty($cat['category_description']) ? ' - ' . htmlspecialchars($cat['category_description']) : '') . '
' . "\n"; + $ret .= str_repeat(' ', $level * 2).'• ' . (!empty($cat['category_icon']) ? '' . $cat['category_name'] . ' ' : '') . htmlspecialchars($cat['category_name']) . (!empty($cat['category_description']) ? ' - ' . htmlspecialchars($cat['category_description']) : '') . ''; break; case 1: case 2: @@ -1525,7 +1525,7 @@ function serendipity_generateCategoryList($cats, $select = array(0), $type = 0, htmlspecialchars($cat['category_name'])); } else { $ret .= sprintf( - '%s%s
', + '%s%s', str_repeat(' ', $level * 3), serendipity_categoryURL($cat, 'serendipityHTTPPath'), htmlspecialchars($cat['category_description']), diff --git a/include/functions_entries_admin.inc.php b/include/functions_entries_admin.inc.php index 2c1faa6a..7cec82dc 100644 --- a/include/functions_entries_admin.inc.php +++ b/include/functions_entries_admin.inc.php @@ -128,7 +128,7 @@ function serendipity_printEntryForm($targetURL, $hiddens = array(), $entry = arr } if (!empty($serendipity['GET']['url'])) { - $entry['body'] .= "\n" . '
' . $entry['title'] . ''; + $entry['body'] .= "\n" . '' . $entry['title'] . ''; } $hidden = ''; @@ -423,16 +423,15 @@ function serendipity_printEntryForm($targetURL, $hiddens = array(), $entry = arr
- />
+ /> /> 		-
+
-
@@ -491,7 +490,6 @@ if (!$serendipity['wysiwyg']) { -
'; - echo $sql . '
'; + echo '' . $query . ''; + echo '' . $sql . ''; } $image_id = serendipity_db_insert_id('images', 'id'); @@ -580,8 +580,8 @@ function serendipity_insertImageInDatabase($filename, $directory, $authorid = 0, $sql = serendipity_db_query($query); if (is_string($sql)) { - echo $query . '
'; - echo $sql . '
'; + echo '' . $query . ''; + echo '' . $sql . ''; } $image_id = serendipity_db_insert_id('images', 'id'); @@ -1493,10 +1493,10 @@ function serendipity_displayImageList($page = 0, $lineBreak = NULL, $manage = fa ); foreach ($aResultSet AS $sKey => $sFile) { if ($sFile['directory']) { - if ($debug) echo "{$sFile['relpath']} is a directory.
"; + if ($debug) echo "{$sFile['relpath']} is a directory."; array_push($paths, $sFile); } else { - if ($debug) echo "{$sFile['relpath']} is a file.
"; + if ($debug) echo "{$sFile['relpath']} is a file."; // Store the file in our array, remove any ending slashes $aFilesOnDisk[$sFile['relpath']] = 1; } @@ -1530,13 +1530,13 @@ function serendipity_displayImageList($page = 0, $lineBreak = NULL, $manage = fa } $sFileName = $sFile['path'] . $sFile['name'] . (empty($sFile['extension']) ? '' : '.' . $sFile['extension']); - if ($debug) echo "

File name is $sFileName,
thumbnail is $sThumbNailFile

"; + if ($debug) echo "

File name is $sFileName, thumbnail is $sThumbNailFile

"; unset($aResultSet[$sKey]); if (isset($aFilesOnDisk[$sFileName])) { unset($aFilesOnDisk[$sFileName]); } else { - if ($debug) echo "Deleting Image {$sFile['id']}
\n"; + if ($debug) echo "Deleting Image {$sFile['id']}"; serendipity_deleteImage($sFile['id']); ++$nCount; } @@ -2065,7 +2065,7 @@ function serendipity_directoryACL(&$paths, $type = 'read') { static $debug = false; if ($debug) { - echo "Applying ACL for mode '$type'.
\n"; + echo "Applying ACL for mode '$type'."; } if (!is_array($paths)) { @@ -2130,19 +2130,19 @@ function serendipity_directoryACL(&$paths, $type = 'read') { if ($granted === false) { // We are not allowed to access this element if ($debug) { - echo "ACL for " . $info['relpath'] . " DENIED.
\n"; + echo "ACL for " . $info['relpath'] . " DENIED."; } unset($paths[$idx]); } else { if ($debug) { - echo "ACL for " . $info['relpath'] . " granted.
\n"; + echo "ACL for " . $info['relpath'] . " granted."; } } } if (count($paths) < $startCount) { if ($debug) { - echo "ACL denied all.
\n"; + echo "ACL denied all."; } return false; } @@ -2789,10 +2789,10 @@ function serendipity_prepareMedia(&$file, $url = '') { if (!$mimeicon) { $mimeicon = serendipity_getTemplateFile('admin/img/mime_unknown.png'); } - $file['preview'] .= ''. $file['mime'] .'
- ' . (($file['hotlink']) ? MEDIA_HOTLINKED : $file['mime']) .' -'; + $file['preview'] .= ''. $file['mime'] .'- ' . (($file['hotlink']) ? MEDIA_HOTLINKED : $file['mime']) .' -'; if ($url) { $file['preview_url'] = $url .'&serendipity[image]='. $file['id']; - $file['preview'] .= '
' . $file['name'] . (empty($file['extension']) ? '' : '.' . $file['extension']) . ''; + $file['preview'] .= '' . $file['name'] . (empty($file['extension']) ? '' : '.' . $file['extension']) . ''; } } diff --git a/include/functions_plugins_admin.inc.php b/include/functions_plugins_admin.inc.php index a0168527..806e5de2 100644 --- a/include/functions_plugins_admin.inc.php +++ b/include/functions_plugins_admin.inc.php @@ -155,7 +155,7 @@ function show_plugins($event_only = false, $sidebars = null) $name = htmlspecialchars($bag->get('name')); $desc = htmlspecialchars($bag->get('description')); - $desc .= '
' . VERSION . ': ' . $bag->get('version') . ''; + $desc .= '' . VERSION . ': ' . $bag->get('version') . ''; $title = serendipity_plugin_api::get_plugin_title($plugin, '[' . $name . ']'); diff --git a/include/functions_rss.inc.php b/include/functions_rss.inc.php index 3740a949..bbd3a76f 100644 --- a/include/functions_rss.inc.php +++ b/include/functions_rss.inc.php @@ -70,7 +70,7 @@ function serendipity_printEntries_rss(&$entries, $version, $comments = false, $f $entry['body'] .= ' ' . $entry['extended']; $ext = ''; } elseif ($entry['exflag']) { - $ext = '
' . sprintf(VIEW_EXTENDED_ENTRY, htmlspecialchars($entry['title'])) . ''; + $ext = '' . sprintf(VIEW_EXTENDED_ENTRY, htmlspecialchars($entry['title'])) . ''; } else { $ext = ''; } diff --git a/include/functions_trackbacks.inc.php b/include/functions_trackbacks.inc.php index fdf1f4f2..6167ba40 100644 --- a/include/functions_trackbacks.inc.php +++ b/include/functions_trackbacks.inc.php @@ -673,7 +673,7 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $old_references = serendipity_db_query("SELECT * FROM {$serendipity['dbPrefix']}references WHERE (type = '' OR type IS NULL) AND entry_id = " . (int)$id, false, 'assoc'); if ($debug && is_string($old_references)) { - echo $old_references . "
\n"; + echo '' . $old_references . ""; } if (is_array($old_references) && count($old_references) > 0) { @@ -684,15 +684,15 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $saved_urls[$old_reference['link']] = true; } } - if ($debug) echo "Got references in dry run: 
" . print_r($current_references, true) . "

\n"; + if ($debug) echo "Got references in dry run: 
" . print_r($current_references, true) . "
\n"; } else { // A dry-run was called previously and restorable references are found. Restore them now. $del = serendipity_db_query("DELETE FROM {$serendipity['dbPrefix']}references WHERE (type = '' OR type IS NULL) AND entry_id = " . (int)$id); if ($debug && is_string($del)) { - echo $del . "
\n"; + echo '' . $del . ""; } - if ($debug) echo "Deleted references.
\n"; + if ($debug) echo "Deleted references."; if (is_array($old_references) && count($old_references) > 0) { $current_references = array(); @@ -702,12 +702,12 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $q = serendipity_db_insert('references', $old_reference, 'show'); $cr = serendipity_db_query($q); if ($debug && is_string($cr)) { - echo $cr . "
\n"; + echo '' . $cr . ""; } } } - if ($debug) echo "Got references in final run: 
" . print_r($current_references, true) . "

\n"; + if ($debug) echo "Got references in final run: 
" . print_r($current_references, true) . "
\n"; } if (!preg_match_all('@]+?href\s*=\s*["\']?([^\'" >]+?)[ \'"][^>]*>(.+?)@i', $text, $matches)) { @@ -729,13 +729,13 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $checked_locations = array(); serendipity_plugin_api::hook_event('backend_trackbacks', $locations); for ($i = 0, $j = count($locations); $i < $j; ++$i) { - if ($debug) echo "Checking {$locations[$i]}...
\n"; + if ($debug) echo "Checking {$locations[$i]}..."; if ($locations[$i][0] == '/') { $locations[$i] = 'http' . (!empty($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) != 'off' ? 's' : '') . '://' . $_SERVER['HTTP_HOST'] . $locations[$i]; } if (isset($checked_locations[$locations[$i]])) { - if ($debug) echo "Already checked.
\n"; + if ($debug) echo "Already checked."; continue; } @@ -756,7 +756,7 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $row = serendipity_db_query($query, true, 'num'); if ($debug && is_string($row)) { - echo $row . "
\n"; + echo '' . $row . ""; } $names[$i] = strip_tags($names[$i]); @@ -766,31 +766,31 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f } if ($row[0] > 0 && isset($saved_references[$locations[$i] . $names[$i]])) { - if ($debug) echo "Found references for $id, skipping rest
\n"; + if ($debug) echo "Found references for $id, skipping rest"; continue; } if (!isset($serendipity['noautodiscovery']) || !$serendipity['noautodiscovery']) { if (!$dry_run) { if (!isset($saved_urls[$locations[$i]])){ - if ($debug) echo "Enabling autodiscovery.
\n"; + if ($debug) echo "Enabling autodiscovery."; serendipity_reference_autodiscover($locations[$i], $url, $author, $title, serendipity_trackback_excerpt($text)); } - elseif ($debug) echo "This reference was already used before in $id and therefore will not be trackbacked again.
\n"; + elseif ($debug) echo "This reference was already used before in $id and therefore will not be trackbacked again."; } elseif ($debug) { - echo "Dry run: Skipping autodiscovery
\n"; + echo "Dry run: Skipping autodiscovery"; } $checked_locations[$locations[$i]] = true; // Store trackbacked link so that no further trackbacks will be sent to the same link } elseif ($debug) { - echo "Skipping full autodiscovery
\n"; + echo "Skipping full autodiscovery"; } } $del = serendipity_db_query("DELETE FROM {$serendipity['dbPrefix']}references WHERE entry_id=" . (int)$id . " AND (type = '' OR type IS NULL)"); if ($debug && is_string($del)) { - echo $del . "
\n"; + echo '' . $del . ""; } - if ($debug) echo "Deleted references again.
\n"; + if ($debug) echo "Deleted references again."; if (!is_array($old_references)) { $old_references = array(); @@ -811,7 +811,7 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $query .= (int)$current_references[$locations[$i] . $names[$i]]['id'] . ", " . (int)$id . ", '" . $i_link . "', '" . $i_location . "')"; $ins = serendipity_db_query($query); if ($debug && is_string($ins)) { - echo $ins . "
\n"; + echo '' . $ins . ""; } $duplicate_check[$locations[$i] . $names[$i]] = true; } else { @@ -819,7 +819,7 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $query .= (int)$id . ", '" . $i_link . "', '" . $i_location . "')"; $ins = serendipity_db_query($query); if ($debug && is_string($ins)) { - echo $ins . "
\n"; + echo '' . $ins . ""; } $old_references[] = array( @@ -832,13 +832,13 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f } if ($debug) { - echo "Current lookup for {$locations[$i]}{$names[$i]} is 
" . print_r($current_references[$locations[$i] . $names[$i]], true) . "

\n"; - echo $query . "
\n"; + echo "Current lookup for {$locations[$i]}{$names[$i]} is 
" . print_r($current_references[$locations[$i] . $names[$i]], true) . "
\n"; + echo '' . $query . ""; } } if ($debug) { - echo "Old/Saved locations: 
" . print_r($old_references, true) . "

\n"; + echo "Old/Saved locations: 
" . print_r($old_references, true) . "
\n"; } // Add citations @@ -850,7 +850,7 @@ function serendipity_handle_references($id, $author, $title, $text, $dry_run = f $cite = serendipity_db_query($query); if ($debug && is_string($cite)) { - echo $cite . "
\n"; + echo '' . $cite . ""; } } } diff --git a/include/plugin_api.inc.php b/include/plugin_api.inc.php index 29812a75..c73d2ff7 100644 --- a/include/plugin_api.inc.php +++ b/include/plugin_api.inc.php @@ -171,7 +171,7 @@ class serendipity_plugin_api $plugin->install(); } else { $serendipity['debug']['pluginload'][] = "Loading plugin failed painfully. File not found?"; - echo ERROR . ': ' . $key . ' (' . $pluginPath . ')
'; + echo '' . ERROR . ': ' . $key . ' (' . $pluginPath . ')'; } return $key; diff --git a/include/plugin_internal.inc.php b/include/plugin_internal.inc.php index 8af89b5c..fcda5f87 100644 --- a/include/plugin_internal.inc.php +++ b/include/plugin_internal.inc.php @@ -1716,12 +1716,12 @@ class serendipity_categories_plugin extends serendipity_plugin { } if (!$smarty && $is_form) { - $html .= '

'; + $html .= '
'; } if (!$smarty) { $html .= sprintf( - '

%s
', + '
%s
', $serendipity['serendipityHTTPPath'] . $serendipity['indexFile'] . '?frontpage', ALL_CATEGORIES, diff --git a/include/template_api.inc.php b/include/template_api.inc.php index 00d71123..77c662f2 100644 --- a/include/template_api.inc.php +++ b/include/template_api.inc.php @@ -129,7 +129,7 @@ class serendipity_smarty_emulator { } elseif (function_exists($funcname)) { return call_user_func($funcname, $params, $this); } else { - return "ERROR: " . htmlspecialchars($funcname) . " NOT FOUND.
\n"; + return "ERROR: " . htmlspecialchars($funcname) . " NOT FOUND."; } } diff --git a/serendipity_admin.php b/serendipity_admin.php index 6d674042..12a8926c 100644 --- a/serendipity_admin.php +++ b/serendipity_admin.php @@ -504,9 +504,8 @@ if ($use_installer) { -
-
-
+
+