diff --git a/include/admin/installer.inc.php b/include/admin/installer.inc.php
index 38333bd2..20c23bab 100644
--- a/include/admin/installer.inc.php
+++ b/include/admin/installer.inc.php
@@ -40,19 +40,19 @@ $data['basedir'] = $basedir;
* @return string returned String
*/
function serendipity_installerResultDiagnose($result, $s) {
- global $errorCount;
+ global $errorCount, $data;
if ( $result === S9Y_I_SUCCESS ) {
- $data['i_success'] = true;
- return ''. $s .'';
+ $data['i_success'] = true; // we dont need data here explicitely, but we keep it for possible future purposes
+ return ''. $s .'';
}
if ( $result === S9Y_I_WARNING ) {
$data['i_warning'] = true;
- return ''. $s .' [?]';
+ return ''. $s .' [?]';
}
if ( $result === S9Y_I_ERROR ) {
$errorCount++;
$data['i_error'] = true;
- return ''. $s .' [!]';
+ return ''. $s .' [!]';
}
}
diff --git a/include/admin/tpl/installer.inc.tpl b/include/admin/tpl/installer.inc.tpl
index fd67e003..ce419142 100644
--- a/include/admin/tpl/installer.inc.tpl
+++ b/include/admin/tpl/installer.inc.tpl
@@ -1,14 +1,3 @@
-{** please return correct markup for these serendipity_installerResultDiagnose notices in the upper PHP file
- {if $i_success}
- return ''. $s .'';
- {/if}
- {if $i_warning}
- return ''. $s .' [?]';
- {/if}
- {if $i_error}
- return ''. $s .' [!]';
- {/if}
-**}
{* From configuration to install *}
{if ( sizeof($smarty.post) > 1 && $s9yGETstep == 3 )}
diff --git a/include/admin/tpl/upgrader.inc.tpl b/include/admin/tpl/upgrader.inc.tpl
index 757e16a3..02b782c5 100644
--- a/include/admin/tpl/upgrader.inc.tpl
+++ b/include/admin/tpl/upgrader.inc.tpl
@@ -1,15 +1,3 @@
-{** please return correct markup for these serendipity_upgraderResultDiagnose notices in the upper PHP file
- {if $u_success}
- return ''. $s .'';
- {/if}
- {if $u_warning}
- return ''. $s .'';
- {/if}
- {if $u_error}
- return ''. $s .'';
- {/if}
-**}
-
{if $task_function}
{'Calling %s ...
'|sprintf:(is_array($task['function']) ? $task['function'][0] . '::'. $task['function'][1] : $task['function'])}
{/if}
diff --git a/include/admin/upgrader.inc.php b/include/admin/upgrader.inc.php
index bed9bbf2..36530683 100644
--- a/include/admin/upgrader.inc.php
+++ b/include/admin/upgrader.inc.php
@@ -23,22 +23,22 @@ define('S9Y_U_SUCCESS', 1);
* @return string returned String
*/
function serendipity_upgraderResultDiagnose($result, $s) {
- global $errorCount;
+ global $errorCount, $data;
if ( $result === S9Y_U_SUCCESS ) {
- $data['u_success'] = true;
- return ''. $s .'';
+ $data['u_success'] = true; // we dont need data here explicitely, but we keep it for possible future purposes
+ return ''. $s .'';
}
if ( $result === S9Y_U_WARNING ) {
$data['u_warning'] = true;
- return ''. $s .'';
+ return ''. $s .'';
}
if ( $result === S9Y_U_ERROR ) {
$errorCount++;
$data['u_error'] = true;
- return ''. $s .'';
+ return ''. $s .'';
}
}