Instead of using global JS-variables and ignoring serendipity[textarea]={$view}, this
approach actually uses the variable and therefore reinstates wysiwyg_init.tpl.
ckeditor_custom_config.js (Thx Ian!) is still respected, but the toolbar got restored to the old version. We need an easy way to remove _underline_, for example. It could be extended though.
This fixes #{107} somewhat, as serendipity_image_selector.php is useable now, but still with display errors (and without an upload widget). Probably still a good idea to copy the ML-eapproach of the normal textareas
This also works with htmlnuggets, without using spawnnugget from the core, instead wysiwyg_init.tpl gets reused in the plugin-config.
ckeditor_custom_plugin.js got emptied, the relevant code (which should only be the part that adds the plugins into the toolbar) should be integrated into wysiwyg_init.tpl).
This supports custom ckeditor plugins and a custom ckeditor config
and reads $eventData for
- normal entry form (case1) textareas,
- staticpage (case2) textareas and
- other nugget plugins (case3) textareas.
They all are build differently, therfore we needed three cases.
Please test!
Based to following commits
8e26bd9 prepare core ckeditor for custom config and plugins
44ea050 fix virtual js
40609d8 add backend_footer hook
References #72
– necessary layout changes
– move toggle nav button
– incorporate user menu back into main nav
– basic styles required for off-canvas nav
– adapt typography, remove some redundant styles
– adapt toggle JS
Partial manual revert of 168cb146ea.
Please note that this does *not* contain any changes to the UI as
discussed; those will follow later.
References #41
Removes obsolete wrench icon; replaces icon-off with icon-logout
and icon-eye with icon-globe or icon-zoom-in; adds icon-cancel as
state indicator for smallscreen navigation.
responsive-nav.js is nice, but it imposes a performance issue and
we already have code for that behaviour. This is much simpler, but
still lacks some accessibility feature (aria-hidden). I'll add
those later after some proper accessibility testing.
Also moved reference to serendipity_editor.js before the closing
body element. This way, jQuery's $(document).ready() equals
$(window).load(), so we don't have to use that any longer.
This really isn't necessary – there is a warning plus a confirm or
abort dialogue on the following page. I don't see extra value for
users in the JS-based confirm/abort dialogue.
NOTE: This is probably only temporary so that unported JS functions
will still work. In the end, we'll want to references this
file right before the closing </body> tag since it's going
to get pretty big.
onli
Ian
Garvin Hicking
Matthias Mees