python/gcd-parser
1
0
Fork 0
Code Issues 5 Pull Requests Activity

Fixed sum crash when file size is a mult of 16384 #6

Merged
ExtReMLapin merged 1 commits from patch-1 into master 2020-05-11 00:21:00 +01:00
Conversation 1 Commits 1 Files Changed 1
+2 -1
ExtReMLapin commented 2020-05-10 21:01:48 +01:00 (Migrated from github.com)
Copy Link
Copy Source

Crash happened when file is mult of 16384, which means last block size is zero and it crashed because of data[-1]

Crash happened when file is mult of 16384, which means last block size is zero and it crashed because of data[-1]
ExtReMLapin commented 2020-05-10 21:02:16 +01:00 (Migrated from github.com)
Copy Link
Copy Source
Traceback (most recent call last):
  File "gcksum.py", line 9, in <module>
    from grmn import ChkSum
  File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/__init__.py", line 3, in <module>
    from .gcd import *
  File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/gcd.py", line 5, in <module>
    from .chksum import ChkSum
  File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/chksum.py", line 12
    throw Exception(data)
                  ^
``` Traceback (most recent call last): File "gcksum.py", line 9, in <module> from grmn import ChkSum File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/__init__.py", line 3, in <module> from .gcd import * File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/gcd.py", line 5, in <module> from .chksum import ChkSum File "/mnt/c/Users/pierr/Desktop/garmin reverse/gcd-parser/grmn/chksum.py", line 12 throw Exception(data) ^ ```
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
mbirth (Markus Birth)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: python/gcd-parser#6